snmvaughan commented on PR #7522: URL: https://github.com/apache/datafusion-comet/pull/7522#issuecomment-6804355892
Rebased onto `main` after #7577 and #7578. The fix is the same, in one commit (`b1aec2525`). What changed comes from the rebase: - #7577: the version check for this fix is its own predicate, `SparkFixes.castsTinyStringToDecimalZero`, with its own table (4.0.5, 4.1.4 and 4.2.1) and rows in `SparkFixesSuite`. - #7578: `Cast` in `expr.proto` has both options, `decimal_tiny_to_zero = 8` and `decimal_skip_integral_digit_limit = 9`. `parse_string_to_decimal` takes both, and `cast_string_to_decimal` now has eight arguments, so it carries `#[allow(clippy::too_many_arguments)]`. - `1e2147483647` now reaches the integral-digit limit before the scale check, so the unit test that pins it passes `skip_integral_digit_limit`, and `test_parse_string_to_decimal_tiny_value_to_negative_scale` runs with and without the setting. - `cast.md` and the audit entry have the SPARK-60119 text next to the paragraphs from #7578. `cargo test -p datafusion-comet-spark-expr` passes (1,329 tests), clippy is clean on `datafusion-comet-spark-expr` and `datafusion-comet`, and the Scala build with `SparkFixesSuite` passes. Could a committer approve the workflow runs for the new commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
