Rachelint commented on code in PR #12395:
URL: https://github.com/apache/datafusion/pull/12395#discussion_r1762218952
##########
datafusion/functions/src/string/common.rs:
##########
@@ -21,17 +21,39 @@ use std::fmt::{Display, Formatter};
use std::sync::Arc;
use arrow::array::{
- new_null_array, Array, ArrayAccessor, ArrayDataBuilder, ArrayIter,
ArrayRef,
- GenericStringArray, GenericStringBuilder, LargeStringArray,
OffsetSizeTrait,
- StringArray, StringBuilder, StringViewArray, StringViewBuilder,
+ make_view, new_null_array, Array, ArrayAccessor, ArrayDataBuilder,
ArrayIter,
+ ArrayRef, ByteView, GenericStringArray, GenericStringBuilder,
LargeStringArray,
+ OffsetSizeTrait, StringArray, StringBuilder, StringViewArray,
StringViewBuilder,
};
use arrow::buffer::{Buffer, MutableBuffer, NullBuffer};
use arrow::datatypes::DataType;
+use arrow_buffer::{NullBufferBuilder, ScalarBuffer};
use datafusion_common::cast::{as_generic_string_array, as_string_view_array};
use datafusion_common::Result;
use datafusion_common::{exec_err, ScalarValue};
use datafusion_expr::ColumnarValue;
+/// Make a `u128` based on the given substr, start(offset to view.offset), and
+/// push into to the given buffers
+pub(crate) fn make_and_append_view(
Review Comment:
It sounds great! and
https://github.com/apache/datafusion/pull/12383#discussion_r1750580081 can be
solved if it is function in arrow-rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
