Rachelint commented on PR #12395:
URL: https://github.com/apache/datafusion/pull/12395#issuecomment-2364458710
> ```
> ++ critcmp main string-view-trim
> group
main string-view-trim
> -----
---- ----------------
> INPUT LEN <= 12/large_string [size=1024, len_before=12, len_after=8]
1.07 45.0±0.03µs ? ?/sec 1.00 42.0±0.03µs
? ?/sec
> INPUT LEN <= 12/large_string [size=4096, len_before=12, len_after=8]
1.07 173.8±0.20µs ? ?/sec 1.00 163.1±0.18µs
? ?/sec
> INPUT LEN <= 12/large_string [size=8192, len_before=12, len_after=8]
1.07 345.0±0.15µs ? ?/sec 1.00 321.9±0.34µs
? ?/sec
> INPUT LEN <= 12/string [size=1024, len_before=12, len_after=8]
1.00 42.3±0.02µs ? ?/sec 1.02 43.3±0.02µs
? ?/sec
> INPUT LEN <= 12/string [size=4096, len_before=12, len_after=8]
1.00 162.9±0.12µs ? ?/sec 1.03 167.2±0.06µs
? ?/sec
> INPUT LEN <= 12/string [size=8192, len_before=12, len_after=8]
1.00 323.2±0.17µs ? ?/sec 1.03 332.3±0.49µs
? ?/sec
> INPUT LEN <= 12/string_view [size=1024, len_before=12, len_after=8]
1.04 42.1±0.08µs ? ?/sec 1.00 40.5±0.04µs
? ?/sec
> INPUT LEN <= 12/string_view [size=4096, len_before=12, len_after=8]
1.02 163.1±0.14µs ? ?/sec 1.00 159.4±0.16µs
? ?/sec
> INPUT LEN <= 12/string_view [size=8192, len_before=12, len_after=8]
1.02 323.0±0.25µs ? ?/sec 1.00 317.1±0.14µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/large_string [size=1024, len_before=64,
len_after=4] 1.00 184.2±0.17µs ? ?/sec 1.01 186.2±0.22µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/large_string [size=4096, len_before=64,
len_after=4] 1.00 740.0±16.98µs ? ?/sec 1.00 741.3±0.94µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/large_string [size=8192, len_before=64,
len_after=4] 1.00 1464.2±2.95µs ? ?/sec 1.01 1482.4±2.26µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string [size=1024, len_before=64,
len_after=4] 1.00 181.8±0.09µs ? ?/sec 1.03
187.6±0.06µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string [size=4096, len_before=64,
len_after=4] 1.00 722.9±0.86µs ? ?/sec 1.03
746.0±0.42µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string [size=8192, len_before=64,
len_after=4] 1.00 1440.5±1.30µs ? ?/sec 1.04
1491.1±3.38µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string_view [size=1024, len_before=64,
len_after=4] 1.00 182.3±0.19µs ? ?/sec 1.01 184.0±3.93µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string_view [size=4096, len_before=64,
len_after=4] 1.00 724.5±1.23µs ? ?/sec 1.01 732.5±0.40µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN <= 12/string_view [size=8192, len_before=64,
len_after=4] 1.00 1443.6±1.95µs ? ?/sec 1.02 1465.6±24.73µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/large_string [size=1024, len_before=64,
len_after=60] 1.07 46.6±0.07µs ? ?/sec 1.00 43.4±0.05µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/large_string [size=4096, len_before=64,
len_after=60] 1.06 179.5±0.27µs ? ?/sec 1.00 168.9±0.19µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/large_string [size=8192, len_before=64,
len_after=60] 1.06 363.9±0.73µs ? ?/sec 1.00 341.8±0.64µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string [size=1024, len_before=64,
len_after=60] 1.00 44.2±0.11µs ? ?/sec 1.02
45.3±0.17µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string [size=4096, len_before=64,
len_after=60] 1.00 168.6±0.13µs ? ?/sec 1.03
174.0±0.30µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string [size=8192, len_before=64,
len_after=60] 1.00 343.9±0.93µs ? ?/sec 1.02
352.1±0.62µs ? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string_view [size=1024, len_before=64,
len_after=60] 1.07 44.6±0.05µs ? ?/sec 1.00 41.7±0.04µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string_view [size=4096, len_before=64,
len_after=60] 1.05 170.7±0.11µs ? ?/sec 1.00 163.0±1.12µs
? ?/sec
> INPUT LEN > 12, OUTPUT LEN > 12/string_view [size=8192, len_before=64,
len_after=60] 1.07 348.4±0.87µs ? ?/sec 1.00 324.8±0.51µs
? ?/sec
> ```
>
> Looks like a reasonable improvement to me
Hi, some other works needed before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
