ted-jenks commented on code in PR #7528:
URL: https://github.com/apache/datafusion-comet/pull/7528#discussion_r4566174364


##########
native/spark-expr/src/conversion_funcs/numeric.rs:
##########
@@ -520,6 +520,16 @@ macro_rules! cast_float_to_int32_up {
     }};
 }
 
+/// 10^scale, or an error for a scale outside 0..=38. Negative scales need
+/// spark.sql.legacy.allowNegativeScaleOfDecimal and can still arrive from the 
Parquet schema
+/// adapter.

Review Comment:
   added the scan fallback here in ca2143a83



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to