comphead commented on code in PR #2857:
URL: 
https://github.com/apache/datafusion-ballista/pull/2857#discussion_r4575367957


##########
ballista/executor/src/standalone.rs:
##########
@@ -190,11 +192,8 @@ pub async fn new_standalone_executor_from_builder(
         };
         let shutdown = crate::shutdown::ShutdownNotifier::new();
         let (stop_send, stop_receive) = tokio::sync::mpsc::channel::<bool>(10);
-        let incoming = TcpIncoming::from(grpc_listener)
-            .with_nodelay(Some(true))
-            .with_keepalive(Some(Duration::from_secs(
-                process_config.grpc_server_config.tcp_keepalive_seconds,

Review Comment:
   is this param still makes sense if not used? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to