sunchao commented on code in PR #7598: URL: https://github.com/apache/datafusion-comet/pull/7598#discussion_r4575401940
########## native/core/src/execution/operators/dynamic_filter/min_max/row_group_limit/reader.rs: ########## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// Review Comment: [P2] Restore the Apache license URL so preflight can pass The new reader file skips the license URL between the opening notice and the warranty paragraph. On this commit, `./dev/release/check-rat.sh HEAD` reports this file as `NOT APPROVED` and exits 1 in both the [upstream preflight](https://github.com/apache/datafusion-comet/actions/runs/43634134887/job/132567096925) and [fork preflight](https://github.com/pingzh/datafusion-comet/actions/runs/43634126335/job/132567104364). Required Checks fails and the build and test jobs are skipped. Use the complete header from `row_group_limit.rs`, including the Apache License 2.0 URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
