viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1763844471
##########
Makefile:
##########
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES)
+# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
+core-arm64-libs:
+ # if the environment variable HAS_OSXCROSS is defined
+ifdef $(HAS_OSXCROSS)
+ cd native && cargo zigbuild -j 1 --target aarch64-apple-darwin --release
+endif
+ cd native && cargo build -j 2 --release
Review Comment:
So for MacOSX build, we need to run both `cargo zigbuild` and `cargo build`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
