parthchandra commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1764003176
##########
Makefile:
##########
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES)
+# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
+core-arm64-libs:
+ # if the environment variable HAS_OSXCROSS is defined
+ifdef $(HAS_OSXCROSS)
+ cd native && cargo zigbuild -j 1 --target aarch64-apple-darwin --release
+endif
+ cd native && cargo build -j 2 --release
+
+# build native libs for amd64 architecture Linux/MacOS on a Linux/amd64
machine/container
+core-amd64-libs:
+ cd native && cargo build -j 2 --release
+ifdef HAS_OSXCROSS
+ rustup target add x86_64-apple-darwin
+ cd native && cargo build -j 2 --target x86_64-apple-darwin --release
+endif
+
+# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
+core-arm64-libs:
Review Comment:
Removed.
##########
Makefile:
##########
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES)
+# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
+core-arm64-libs:
+ # if the environment variable HAS_OSXCROSS is defined
+ifdef $(HAS_OSXCROSS)
Review Comment:
This part is a placeholder for future work to enable MacOS. MacOS Sdk has to
be provided to the Docker file as input and the build-release-comet script will
copy it into the release builder's Docker image.
I removed the option because the build did not succeed but left the work so
we can fix this later. I can remove it if it makes things clearer.
##########
dev/release/comet-rm/Dockerfile:
##########
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG HAS_MACOS_SDK="false"
Review Comment:
I did not try the docker image from zigbuild (yet). I will try it and if it
works, then we can remove the HAS_OSXCROSS portions entirely.
Follow up issue: #947
##########
dev/release/comet-rm/Dockerfile:
##########
@@ -0,0 +1,91 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG HAS_MACOS_SDK="false"
Review Comment:
I did not try the docker image from zigbuild (yet). I will try it and if it
works, then we can remove the HAS_OSXCROSS portions entirely.
Follow up issue: #947
##########
Makefile:
##########
@@ -46,6 +46,30 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES)
+# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
+core-arm64-libs:
+ # if the environment variable HAS_OSXCROSS is defined
+ifdef $(HAS_OSXCROSS)
+ cd native && cargo zigbuild -j 1 --target aarch64-apple-darwin --release
+endif
+ cd native && cargo build -j 2 --release
Review Comment:
Oops. This was a mistake. I experimented with zigbuild for macos. Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
