2010YOUY01 commented on code in PR #27399:
URL: https://github.com/apache/datafusion/pull/27399#discussion_r4583201766


##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -236,27 +241,68 @@ fn array_map_key_range(
 }
 
 /// Immutable build buffers and their durable reservation.
-struct JoinBuildData {
+pub(super) struct JoinBuildData {

Review Comment:
   Some notes about structs related to build-side data, as this PR introduces 
extra complexity on this part:
   
   The final shape split left-side data into `RegularJoinLeftData` and 
`ExistenceJoinLeftData`, with `JoinBuildData` as the common inner part. (better 
to split since some fields are only specific to one path)
   
   This PR only migrates regular joins, requiring temporary indirection:
   
   ```text
   CollectedBuild → RegularJoinLeftData / JoinLeftData
   ```
   
   After migration, we can remove `CollectedBuild` and replace legacy 
`JoinLeftData` with `ExistenceJoinLeftData` to keep it simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to