NoahKusaba commented on code in PR #2852:
URL: 
https://github.com/apache/datafusion-ballista/pull/2852#discussion_r4582097039


##########
ballista/scheduler/src/state/task_builder.rs:
##########
@@ -141,7 +149,11 @@ fn restrict(
             .into_iter()
             .cloned()
             .zip(per_child)
-            .map(|(child, sub)| restrict(child, &sub, false, resolver))
+            .map(|(child, sub)| {
+                let restricted = restrict(child, &sub, false, resolver)?;
+                ensure_branch_restricted(&restricted, &sub)?;

Review Comment:
   When did you want to get ballista 56 out by? It would be nice to also close 
#2854 as well before release.
   I'll try to get the single-task fallback suggestion you made sometime 
tomorrow, so as not to unblock the 56 release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to