morristai commented on code in PR #26634:
URL: https://github.com/apache/datafusion/pull/26634#discussion_r4584338929


##########
datafusion/physical-optimizer/src/projection_pushdown.rs:
##########
@@ -363,7 +374,28 @@ impl<'a> JoinFilterRewriter<'a> {
         let depends_on_other_side =
             self.depends_on_join_side(&expr, self.join_side.negate())?;
         if depends_on_other_side || is_volatile(&expr) {
-            return expr.map_children(|expr| self.rewrite(expr));
+            // The top-level conjuncts carry no evaluation order: the logical 
optimizer splits the

Review Comment:
   Done. `try_push_down_projection` now splits the filter with 
`split_conjunction` first and rewrites each conjunct on its own. The `conjunct` 
parameter is removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to