alamb commented on code in PR #26634:
URL: https://github.com/apache/datafusion/pull/26634#discussion_r4590932787
##########
datafusion/physical-optimizer/src/projection_pushdown.rs:
##########
@@ -767,6 +785,117 @@ mod test {
Ok(())
}
+ #[tokio::test]
+ async fn does_not_push_down_short_circuiting_expressions() -> Result<()> {
Review Comment:
Can you please rewrite these as .slt tests? It seems like there is no reason
we need to write it as rust
##########
datafusion/physical-optimizer/src/projection_pushdown.rs:
##########
@@ -767,6 +785,117 @@ mod test {
Ok(())
}
+ #[tokio::test]
+ async fn does_not_push_down_short_circuiting_expressions() -> Result<()> {
Review Comment:
I thnk only the `coalesce` one is not already redundant -- so just porting
it it to slt would improve this PR
##########
datafusion/physical-optimizer/src/projection_pushdown.rs:
##########
@@ -363,6 +377,9 @@ impl<'a> JoinFilterRewriter<'a> {
let depends_on_other_side =
self.depends_on_join_side(&expr, self.join_side.negate())?;
if depends_on_other_side || is_volatile(&expr) {
+ if expr.short_circuits() {
Review Comment:
this now seems reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]