kazuyukitanimura commented on code in PR #7352:
URL: https://github.com/apache/datafusion-comet/pull/7352#discussion_r4591949238


##########
docs/source/contributor-guide/ci.md:
##########
@@ -169,6 +168,42 @@ If you cannot enable Actions on your fork, say so on the 
pull request. Nothing e
 tier for you before the queue does, so a maintainer may ask you to reproduce a 
failure with
 [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first.
 
+### When the fork check finds no run
+
+When no run of your fork exists for the pull request's head commit, `CI 
(fork)` says one of two
+things:
+
+- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` 
workflow. Usually
+  GitHub Actions was never enabled on the fork, or no branch that includes the 
fork workflows has
+  been pushed to it. GitHub shows this check as failed because it asks you to 
act. It does not block
+  merging. The check says only that no run of your fork was found for this 
commit. A pull request
+  opened before the PR tier moved to forks can still have results of the PR 
tier from here, as
+  [below](#when-the-fork-check-finds-no-run) says, and otherwise a reviewer 
has no CI result to go
+  on.
+- **No fork CI run for this commit.** The workflow exists but has no run for 
this commit. Either
+  the run has not appeared yet, or the commit was pushed before Actions was 
enabled.
+
+Either way, the fix is the three steps above, followed by a new push:

Review Comment:
   The old sentence listed "the branch does not include the fork workflows" as 
a cause, and I think it belongs back in this bullet. Say someone enables 
Actions and syncs their fork's main, but their PR branch predates #7311. Then 
getWorkflow finds an active ci_fork.yml, the branch push starts nothing, and 
the mirror reports the neutral No fork CI run for this commit. That is also the 
case the rollout paragraph describes. As written, someone in that state could 
read this as "wait for the run to appear." Could we write "Either the run has 
not appeared yet, your branch does not include the fork workflows, or the 
commit was pushed before Actions was enabled"? Then "Either way, the fix is..." 
doesn't quite fit the "not appeared yet" case. Maybe "If your fork's Actions 
tab has no run for this commit, the fix is..."?



##########
docs/source/contributor-guide/ci.md:
##########
@@ -169,6 +168,42 @@ If you cannot enable Actions on your fork, say so on the 
pull request. Nothing e
 tier for you before the queue does, so a maintainer may ask you to reproduce a 
failure with
 [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first.
 
+### When the fork check finds no run
+
+When no run of your fork exists for the pull request's head commit, `CI 
(fork)` says one of two
+things:
+
+- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` 
workflow. Usually
+  GitHub Actions was never enabled on the fork, or no branch that includes the 
fork workflows has
+  been pushed to it. GitHub shows this check as failed because it asks you to 
act. It does not block
+  merging. The check says only that no run of your fork was found for this 
commit. A pull request
+  opened before the PR tier moved to forks can still have results of the PR 
tier from here, as
+  [below](#when-the-fork-check-finds-no-run) says, and otherwise a reviewer 
has no CI result to go
+  on.

Review Comment:
   Thanks for reworking this bullet. Two small things in the new sentence. 
"Otherwise a reviewer has no CI result to go on" goes a bit further than the 
check can show. The preflight checks, Required Checks, and any run-* suite 
still run here, as the top of this section says, and this PR's own Preflight 
run shows that. Could it say that the PR tier has not run for this commit 
instead? Also, the "below" link goes to #when-the-fork-check-finds-no-run, 
which is this subsection's own heading, so it jumps up rather than down to the 
rollout paragraph. Maybe something like: "...can still have results of the PR 
tier from here, as the last paragraph of this section says. Otherwise the PR 
tier has not run for this commit, and only the preflight checks and any run-* 
suites have run here."



##########
docs/source/contributor-guide/ci.md:
##########
@@ -169,6 +168,42 @@ If you cannot enable Actions on your fork, say so on the 
pull request. Nothing e
 tier for you before the queue does, so a maintainer may ask you to reproduce a 
failure with
 [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first.
 
+### When the fork check finds no run
+
+When no run of your fork exists for the pull request's head commit, `CI 
(fork)` says one of two
+things:
+
+- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` 
workflow. Usually
+  GitHub Actions was never enabled on the fork, or no branch that includes the 
fork workflows has
+  been pushed to it. GitHub shows this check as failed because it asks you to 
act. It does not block
+  merging. The check says only that no run of your fork was found for this 
commit. A pull request
+  opened before the PR tier moved to forks can still have results of the PR 
tier from here, as
+  [below](#when-the-fork-check-finds-no-run) says, and otherwise a reviewer 
has no CI result to go
+  on.
+- **No fork CI run for this commit.** The workflow exists but has no run for 
this commit. Either
+  the run has not appeared yet, or the commit was pushed before Actions was 
enabled.
+
+Either way, the fix is the three steps above, followed by a new push:
+
+```shell
+# 1. Enable Actions in your fork's Actions tab, then:
+git fetch upstream
+git push origin upstream/main:main   # 2. sync your fork's main (or use "Sync 
fork" on GitHub)
+git merge upstream/main              # 3. bring the fork workflows into your 
branch (or rebase)
+git push                             # starts a Comet CI (fork run) in your 
fork

Review Comment:
   Step 2 above asks readers to rebase onto main, and this line offers "(or 
rebase)". After a rebase, the plain git push on the next line is rejected as a 
non-fast-forward. Could the comment say to push with git push 
--force-with-lease after a rebase, as development.md asks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to