alamb commented on PR #12488: URL: https://github.com/apache/datafusion/pull/12488#issuecomment-2358588230
> For example when removing ScalarValue::Dictionary I did some non-obvious chances that require actual review. BTW I think the most important potential concern for this change is that arrays will be cast at runtime (e.g. when comparing a `Dictionary(String)` column and a `String` scalar, it is very important that the Dictionary column is not cast to a `StringArray` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
