alamb commented on PR #12488: URL: https://github.com/apache/datafusion/pull/12488#issuecomment-2358577025
> Thanks @findepi > > > Do you think it could help to have it land faster if it was done in small steps? > > Definitely as it would make it easier to review. I opened the PR just to make sure that the same approach would be applicable as we remove more types (which i presume was very successful as we were able to identify some key issues that need attention). Once we reach consensus I was planning splitting my work into smaller PRs. From my point of view, there is pretty broad consensus that having ScalarValue mirror the physical representation (e.g. `ScalarValue::Utf8`, `ScalarValue::UtfView`, `ScalarValue::LargeUtf8`) is non ideal The challenge is, as @findepi implies, figuring out how to make the changes incrementally (both to keep the change possible to review as well as to give downstream consumers time to absorb the change) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
