jackylee-ch commented on code in PR #25694:
URL: https://github.com/apache/datafusion/pull/25694#discussion_r4599526329
##########
docs/source/library-user-guide/upgrading/56.0.0.md:
##########
@@ -1014,6 +1014,20 @@ Two differences for operators that still implement
`supports_limit_pushdown`:
operator, as it does above `CoalescePartitionsExec`, and is copied below as
an early-stop fetch.
+### Statistics must have one `ColumnStatistics` per schema field
Review Comment:
Confirmed, `main` is `57.0.0-dev`; moved to `57.0.0.md` in 6e23b65f8.
##########
datafusion/physical-plan/src/operator_statistics/mod.rs:
##########
@@ -3089,4 +3082,47 @@ mod tests {
assert_eq!(stats_b.base.num_rows, Precision::Inexact(50));
Ok(())
}
+
+ /// The walk rejects an operator or provider whose number of column
+ /// statistics differs from the number of fields.
+ #[test]
+ fn test_wrong_column_statistics_count_is_rejected() {
Review Comment:
Not adding: the check is a plain `len == len`, so the test would only assert
`0 == 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]