jackylee-ch commented on code in PR #25694:
URL: https://github.com/apache/datafusion/pull/25694#discussion_r4599529355
##########
datafusion/physical-plan/src/statistics.rs:
##########
@@ -583,6 +586,7 @@ impl StatisticsContext {
provider.compute_statistics_with_args(plan, &child_extended,
args)?
{
let (statistics, extensions) = computed.into_parts();
+ validate_column_statistics(plan, &statistics,
Some(provider.as_ref()))?;
let extensions = if extensions.is_empty() {
Review Comment:
Not adding: the cache key includes the partition and validation runs before
the store, so a cached overall result cannot mask a bad `Some(0)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]