abp002 commented on PR #26967: URL: https://github.com/apache/datafusion/pull/26967#issuecomment-6955886023
Thanks for the review! Pushed: - `EquivalenceClass::new` inserts all the members and promotes once. - Applied the suggestions: the real index, `assert_eq!` and the two slt comments. - Each new slt query has an `EXPLAIN`. - The description no longer mentions the `IN` test, and says where the promotion runs now. I opened #27537 for the two classes that refer to each other, with your query and the three steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
