mbutrovich commented on PR #27228:
URL: https://github.com/apache/datafusion/pull/27228#issuecomment-6958770626

   @shehabgamin, #27399 moves inner, left, right, and full hash joins to a new 
probe path (`BatchedJoinProcessor`), behind 
`datafusion.execution.enable_migration_hash_join`, which defaults to `true`. 
With the flag on, `HashJoinStream` handles only semi, anti, mark, and 
null-aware joins. This PR adds the `Right` single-join check 
([`check_single_matches`](https://github.com/apache/datafusion/blob/5dc676491068901c50e9faf4d809b6cd286bf9ce/datafusion/physical-plan/src/joins/hash_join/stream.rs#L219-L240))
 and the `Left` one 
([`single_matches`](https://github.com/apache/datafusion/blob/5dc676491068901c50e9faf4d809b6cd286bf9ce/datafusion/physical-plan/src/joins/hash_join/stream.rs#L271-L272))
 to `HashJoinStream`. So whichever of the two PRs lands second needs to either 
add the single-join check to `BatchedJoinProcessor` or send single joins to the 
legacy stream regardless of the flag. Otherwise the check runs only with the 
flag off.
   
   Could `single_join.slt` also run with `enable_migration_hash_join = false`? 
That covers both paths while the flag exists. The legacy path for regular joins 
is planned to be removed after one release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to