ump45nose commented on code in PR #7255:
URL: https://github.com/apache/datafusion-comet/pull/7255#discussion_r4604778870


##########
native/spark-expr/src/conversion_funcs/string.rs:
##########
@@ -3091,6 +3112,46 @@ mod tests {
         );
     }
 
+    #[test]
+    fn extreme_year_session_tz_uses_historic_offset() {

Review Comment:
   Added a Spark-compared regression in dd779109: `CometDateTimeUtilsSuite` now 
has `extreme-year session TZ uses historic zone offset`, which runs the same 
inputs through `checkSparkAnswerAndOperator` (so a Spark fallback cannot hide a 
native regression) in UTC, America/Los_Angeles, Asia/Tokyo and Asia/Colombo. It 
covers the far-past residues that a 1600+rem probe lands after 1883, the 
far-future January cases, and the leap days (`262400-02-29`, `-262400-02-29`).
   
   The Rust unit test in `string.rs` keeps the expected offsets so a wrong 
constant is visible without a Spark run, but the authoritative comparison is 
now the Spark one you asked for.
   
   Note the heavy CI on this PR is at `action_required` (`CI (fork)`), so the 
Scala suite has not run yet; only `Preflight` and `Required Checks` completed. 
(AI-assisted.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to