marvelefe commented on PR #27470: URL: https://github.com/apache/datafusion/pull/27470#issuecomment-6962728060
> @marvelefe thanks for picking this up! The main issue is that the tree format overwrites operator entries that share a key with a fact (see the comment on `render_tree.rs`); the others are small. > > One small thing for the PR description: `OrderingEquivalenceClass`'s `Display` also changes (it now prints `NULLS FIRST`), so it could be listed under user-facing changes next to `EquivalenceProperties`. Thanks for the feedback. Addressing them @jayzhan211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
