NoahKusaba commented on code in PR #112:
URL: 
https://github.com/apache/datafusion-iceberg/pull/112#discussion_r4608841007


##########
crates/datafusion/src/read/scan.rs:
##########
@@ -150,21 +154,15 @@ impl IcebergDataSourceBuilder {
     /// # Errors
     ///
     /// Returns an error if the projection is out of bounds for the schema.
-    pub fn build(self) -> Result<IcebergDataSource> {
+    pub fn try_build(self) -> Result<IcebergDataSource> {

Review Comment:
   I wasn't aware of that convention :thinking: .
   I'll leave it out for now as there are bigger fish to fry; although I'm 
still curious to hear gabotechs response.
   Thanks for reviewing :bow: 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to