2010YOUY01 commented on PR #27399: URL: https://github.com/apache/datafusion/pull/27399#issuecomment-6973176259
> Could we add a notice to the [`stream.rs` module doc](https://github.com/apache/datafusion/blob/ef96c9b538feaf05a3000d15d37e25b1d8ef1830/datafusion/physical-plan/src/joins/hash_join/stream.rs#L5-L8)? It should say that inner, left, right, and full joins reach `HashJoinStream` only with `enable_migration_hash_join = false`, and that changes for those join types belong in `BatchedJoinProcessor`. Semi, anti, mark, and null-aware joins still run there by default, so the notice can't cover the whole stream the way the [`# Deprecation` section in `grouped_hash_stream.rs`](https://github.com/apache/datafusion/blob/06fde08f7bf1a13a15e17bff5075a600a0be3cdb/datafusion/physical-plan/src/aggregates/grouped_hash_stream.rs#L5-L18) does for aggregates. #27228 shows the risk. It adds the `Left` and `Right` single-join check to `HashJoinStream`, so after this PR that check would run only with the flag off, and the default path would return duplicate rows instead of the error. Whichever of the tw o lands second has to add the check to the new path or route single joins to the legacy stream. I've updated the comments in [804c9ed](https://github.com/apache/datafusion/pull/27399/commits/804c9ed74a6e988e024fc195ede0b59a8c90eea1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
