alamb commented on PR #27210: URL: https://github.com/apache/datafusion/pull/27210#issuecomment-6989498623
> Yes, the table providers are indeed distinct, but logical plan equality doesn't and can't take that into account since TableSource is not required to have a PartialEq implementation. The only discriminator the logical plan has is the TableReference and that's the same for both. That's why it's being augmented here with an identity representing value that is PartialEq. That is a good point -- though I think we could add a PartialEq impl to the TableSource -- which would be a breaking change but that would not be too much of a breaking downstream change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
