comphead commented on code in PR #7674:
URL: https://github.com/apache/datafusion-comet/pull/7674#discussion_r4619980428
##########
native/spark-expr/src/agg_funcs/sum_decimal.rs:
##########
@@ -384,7 +386,7 @@ impl SumDecimalGroupsAccumulator {
sum: Vec::new(),
is_empty: Vec::new(),
result_type,
- precision,
+ bounds: Decimal128Bounds::new(precision),
Review Comment:
Added as `grouped_latches_at_the_result_precision_below_38`, next to the
other grouped tests. Those use `Decimal128(10, 2)` sums far from the limit, so
I kept this one separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]