comphead commented on code in PR #7674:
URL: https://github.com/apache/datafusion-comet/pull/7674#discussion_r4619976125


##########
docs/source/contributor-guide/expression-audits/agg_funcs.md:
##########
@@ -44,6 +44,7 @@
 - Spark 3.4.3 (2026-05-26)
 - Spark 3.5.8 (2026-05-26): aggregate logic identical to 3.4.3
 - Spark 4.0.1 (2026-05-26): aggregate logic identical to 3.5.8; only 
`QueryContext` import path differs. `YearMonthIntervalType` and 
`DayTimeIntervalType` inputs (supported by Spark) fall back to Spark in Comet.
+- Performance (tuned 2026-11-17): the grouped decimal accumulator loads the 
sum's precision bounds once and compares against them on every update and 
merge, instead of calling `Decimal128Type::is_valid_decimal_precision`, which 
release builds keep out of line. Bench builds already inline that call: 2% to 
5% faster on most shapes, the 4-group shape within 1%. Benchmark: 
`benches/decimal_groups.rs`.

Review Comment:
   Done. I dropped the AVG percentages and added the PR link, as you suggested.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to