andygrove opened a new issue, #7713:
URL: https://github.com/apache/datafusion-comet/issues/7713

   ### Describe the bug
   
   The "Install the Gradle distribution" step in 
`.github/actions/setup-iceberg-builder/action.yaml` retries `./gradlew 
--version` up to three times. When the first download fails in a certain way, 
the retries cannot succeed.
   
   Iceberg's `gradlew` fetches `gradle/wrapper/gradle-wrapper.jar` only when 
the file is missing (`gradlew` lines 89-90 at `apache-iceberg-1.11.0`):
   
   ```sh
   if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
       curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar 
https://raw.githubusercontent.com/gradle/gradle/v8.14.4/gradle/wrapper/gradle-wrapper.jar
   fi
   ```
   
   `curl -o` without `--fail` saves an HTTP error response as the jar. Every 
later run then finds the file present, skips the download, and fails on the 
same corrupt jar. The step's retry loop runs three times against that file and 
gives up.
   
   This evicted #7529 from the merge queue on 2026-11-20. The job was `Iceberg 
Spark SQL Tests (Iceberg 1.11) / 
iceberg-spark/iceberg-1.11.0/spark-4.1.3/scala-2.13/java-17/shard-1` in run 
https://github.com/apache/datafusion-comet/actions/runs/44772914094. curl 
received 470 bytes, and every attempt then failed with:
   
   ```
   Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
   Caused by: java.lang.ClassNotFoundException: 
org.gradle.wrapper.GradleWrapperMain
   ##[warning]Gradle distribution download failed (attempt 1 of 3); retrying in 
15s.
   ...
   ##[error]Could not install the Gradle distribution after 3 attempts.
   ```
   
   The same job also logged HTTP 429 responses from Maven Central during 
`./mvnw install`, so the 470 bytes were most likely a rate-limit response from 
`raw.githubusercontent.com`. #7702 tracks the Maven Central throttling, and 
#7705 and #7706 do not cover this download.
   
   ### Steps to reproduce
   
   Make the `raw.githubusercontent.com` request return an error response, for 
example by writing a small non-jar file to 
`apache-iceberg/gradle/wrapper/gradle-wrapper.jar` before the step runs. All 
three attempts fail with `ClassNotFoundException: GradleWrapperMain`.
   
   ### Expected behavior
   
   A failed wrapper jar download is retried, so a single transient error does 
not fail the job.
   
   ### Additional context
   
   Possible fixes, in the composite step before each attempt:
   
   - Delete `gradle/wrapper/gradle-wrapper.jar` unless it is a valid jar, for 
example when `unzip -tq` fails on it, so `gradlew` downloads it again.
   - Or fetch the jar in the step itself with `curl --fail --retry`, using the 
URL that `gradlew` uses, so `gradlew` finds a valid file.
   
   Each Iceberg version pins its own Gradle version in `gradlew`, so the fix 
should read the URL from that file rather than hard-code it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to