andygrove opened a new pull request, #7714: URL: https://github.com/apache/datafusion-comet/pull/7714
## Which issue does this PR close? Closes #7713. ## Rationale for this change The "Install the Gradle distribution" step in `setup-iceberg-builder` retries `./gradlew --version` three times, but the retries do nothing when the wrapper jar download fails. Iceberg does not commit `gradle/wrapper/gradle-wrapper.jar`. Its `gradlew` downloads the jar with `curl -o`, without `--fail`, and only when the file is missing. An error response, such as a 429 from `raw.githubusercontent.com`, gets saved as the jar. Every later attempt then finds the file, skips the download, and fails with `ClassNotFoundException: GradleWrapperMain`. That is how #7529 was evicted from the merge queue on 2026-11-20 ([run](https://github.com/apache/datafusion-comet/actions/runs/44772914094)). ## What changes are included in this PR? After a failed attempt, the step deletes `gradle/wrapper/gradle-wrapper.jar` before retrying, so `gradlew` downloads it again. Every supported Iceberg version (1.8.1, 1.9.1, 1.10.0, 1.11.0) leaves the jar out of the repository and downloads it the same way, so deleting it is always safe. If the jar was fine and the distribution download failed instead, the only cost is fetching the 44 KB jar again. ## How are these changes tested? I ran the step's script locally against Iceberg 1.11.0's `gradlew`, after replacing the jar with 470 random bytes. Without this change, all three attempts fail with `ClassNotFoundException: GradleWrapperMain`. With it, the first attempt fails the same way, the second downloads the jar again and installs Gradle 8.14.4, and the step exits 0. `dev/ci/check-ci-config.py` passes. The Iceberg jobs in this PR's CI run the changed step on the normal path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
