eejbyfeldt commented on issue #5647:
URL: https://github.com/apache/datafusion/issues/5647#issuecomment-2364228167

   Note that @mingmwang (the author of this ticket) had an alternative approach 
here: https://github.com/apache/datafusion/pull/5749 but it seems like it was 
never pushed above the finish line. 
   
   What is good with that approach is that it also helps address other issues 
in the current implementation of grouping sets. For example the current 
implementation will produce incorrect results when there are null values in the 
actual columns. I also looked into creating PR for only fixing that bug in a 
similar way to #5749 but need to spend some more time on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to