Rachelint commented on issue #6906: URL: https://github.com/apache/datafusion/issues/6906#issuecomment-2368191455
> > @Rachelint your implicit idea of using `Vec<String>` to store the state I think is actually quite interesting and maybe we should try that one first: > > It would at least avoid calling `Array::slice` and likely be better than using `GroupsAccumulatorAdapter`, even if we could improve it later with more explciit memory management 🤔 > > So this would effectively be using a `Vec<String>` for state instead of your proposal of using something akin to StringView notated here [#6906 (comment)](https://github.com/apache/datafusion/issues/6906#issuecomment-2355629355) @alamb? I think what @alamb means is that just simply using `Vec<String>` to store the store will be at least not worse than `StringArray + GroupsAccumulatorAdapter`, and it is easy to start from. And after improve it to be not worse than `StringArray + GroupsAccumulatorAdapter`, we can continue to push forward enabling string view by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
