emgeee commented on issue #875: URL: https://github.com/apache/datafusion-python/issues/875#issuecomment-2369110759
These proposals generally sound good to me. I do think care should be taken around the first two points since Dataframe `cache()` and `collect()` methods shadow the underlying rust library and renaming those methods at the python level would be immensely confusing for those coming from the rust library or those seeking to better understand the python layer. The other suggestion I might add is to keep `Datafusion.with_column()` but make it a simple wrapper around `Datafusion.with_columns()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
