palaska commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-ballista/pull/1059#discussion_r1774308525
##########
ballista/core/src/utils.rs:
##########
@@ -62,13 +63,14 @@ use tonic::transport::{Channel, Error, Server};
/// Default session builder using the provided configuration
pub fn default_session_builder(config: SessionConfig) -> SessionState {
- SessionState::new_with_config_rt(
- config,
- Arc::new(
+ SessionStateBuilder::new()
+ .with_default_features()
Review Comment:
previous method did not have the default_features which seemed necessary to
me, please check :)
##########
ballista/core/src/utils.rs:
##########
@@ -252,15 +254,16 @@ pub fn create_df_ctx_with_ballista_query_planner<T:
'static + AsLogicalPlan>(
let session_config = SessionConfig::new()
.with_target_partitions(config.default_shuffle_partitions())
.with_information_schema(true);
- let mut session_state = SessionState::new_with_config_rt(
- session_config,
- Arc::new(
+ let session_state = SessionStateBuilder::new()
+ .with_default_features()
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
