palaska commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-ballista/pull/1059#discussion_r1774312343
##########
ballista/executor/src/executor.rs:
##########
@@ -103,12 +105,22 @@ impl Executor {
concurrent_tasks: usize,
execution_engine: Option<Arc<dyn ExecutionEngine>>,
) -> Self {
+ let scalar_functions = all_default_functions()
Review Comment:
since we have these here, maybe we can remove the code that manually
registers functions in the execution_loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
