alamb commented on code in PR #12269: URL: https://github.com/apache/datafusion/pull/12269#discussion_r1775416740
########## datafusion/physical-plan/src/aggregates/group_values/column_wise.rs: ########## @@ -0,0 +1,314 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::aggregates::group_values::group_value_row::{ + ArrayRowEq, ByteGroupValueBuilder, PrimitiveGroupValueBuilder, +}; +use crate::aggregates::group_values::GroupValues; +use ahash::RandomState; +use arrow::compute::cast; +use arrow::datatypes::{ + Date32Type, Date64Type, Float32Type, Float64Type, Int16Type, Int32Type, Int64Type, + Int8Type, UInt16Type, UInt32Type, UInt64Type, UInt8Type, +}; +use arrow::record_batch::RecordBatch; +use arrow_array::{Array, ArrayRef}; +use arrow_schema::{DataType, SchemaRef}; +use datafusion_common::hash_utils::create_hashes; +use datafusion_common::{DataFusionError, Result}; +use datafusion_execution::memory_pool::proxy::{RawTableAllocExt, VecAllocExt}; +use datafusion_expr::EmitTo; +use datafusion_physical_expr::binary_map::OutputType; + +use hashbrown::raw::RawTable; + +/// Compare GroupValue Rows column by column +pub struct GroupValuesColumn { + /// The output schema + schema: SchemaRef, + + /// Logically maps group values to a group_index in + /// [`Self::group_values`] and in each accumulator + /// + /// Uses the raw API of hashbrown to avoid actually storing the + /// keys (group values) in the table + /// + /// keys: u64 hashes of the GroupValue + /// values: (hash, group_index) + map: RawTable<(u64, usize)>, + + /// The size of `map` in bytes + map_size: usize, + + /// The actual group by values, stored column-wise. Compare from + /// the left to right, each column is stored as `ArrayRowEq`. + /// This is shown faster than the row format + group_values: Vec<Box<dyn ArrayRowEq>>, + + /// reused buffer to store hashes + hashes_buffer: Vec<u64>, + + /// Random state for creating hashes + random_state: RandomState, +} + +impl GroupValuesColumn { + pub fn try_new(schema: SchemaRef) -> Result<Self> { + let map = RawTable::with_capacity(0); + Ok(Self { + schema, + map, + map_size: 0, + group_values: vec![], + hashes_buffer: Default::default(), + random_state: Default::default(), + }) + } +} + +impl GroupValues for GroupValuesColumn { + fn intern(&mut self, cols: &[ArrayRef], groups: &mut Vec<usize>) -> Result<()> { + let n_rows = cols[0].len(); + + if self.group_values.is_empty() { + let mut v = Vec::with_capacity(cols.len()); + + for f in self.schema.fields().iter() { + let nullable = f.is_nullable(); + match f.data_type() { + &DataType::Int8 => { + let b = PrimitiveGroupValueBuilder::<Int8Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Int16 => { + let b = PrimitiveGroupValueBuilder::<Int16Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Int32 => { + let b = PrimitiveGroupValueBuilder::<Int32Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Int64 => { + let b = PrimitiveGroupValueBuilder::<Int64Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::UInt8 => { + let b = PrimitiveGroupValueBuilder::<UInt8Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::UInt16 => { + let b = PrimitiveGroupValueBuilder::<UInt16Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::UInt32 => { + let b = PrimitiveGroupValueBuilder::<UInt32Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::UInt64 => { + let b = PrimitiveGroupValueBuilder::<UInt64Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Float32 => { + let b = PrimitiveGroupValueBuilder::<Float32Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Float64 => { + let b = PrimitiveGroupValueBuilder::<Float64Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Date32 => { + let b = PrimitiveGroupValueBuilder::<Date32Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Date64 => { + let b = PrimitiveGroupValueBuilder::<Date64Type>::new(nullable); + v.push(Box::new(b) as _) + } + &DataType::Utf8 => { + let b = ByteGroupValueBuilder::<i32>::new(OutputType::Utf8); + v.push(Box::new(b) as _) + } + &DataType::LargeUtf8 => { + let b = ByteGroupValueBuilder::<i64>::new(OutputType::Utf8); + v.push(Box::new(b) as _) + } + &DataType::Binary => { + let b = ByteGroupValueBuilder::<i32>::new(OutputType::Binary); + v.push(Box::new(b) as _) + } + &DataType::LargeBinary => { + let b = ByteGroupValueBuilder::<i64>::new(OutputType::Binary); + v.push(Box::new(b) as _) + } + dt => todo!("{dt} not impl"), Review Comment: in https://github.com/apache/datafusion/pull/12620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
