comphead commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1775793749
##########
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##########
@@ -60,11 +61,13 @@ pub trait ArrayRowEq: Send + Sync {
fn take_n(&mut self, n: usize) -> ArrayRef;
}
+/// An implementation of [`ArrayRowEq`] for primitive types.
pub struct PrimitiveGroupValueBuilder<T: ArrowPrimitiveType> {
group_values: Vec<T::Native>,
nulls: Vec<bool>,
Review Comment:
should be it a BooleanArray? so this null checks will be faster and in 1
place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
