jayzhan211 commented on code in PR #12617: URL: https://github.com/apache/datafusion/pull/12617#discussion_r1776419786
########## datafusion/physical-plan/src/aggregates/group_values/column_wise.rs: ########## @@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType; use hashbrown::raw::RawTable; -/// Compare GroupValue Rows column by column +/// A [`GroupValues`] that stores multiple columns of group values. Review Comment: In Rows implementation, we convert (1, 'a') to row and compare against it. In Column implementation, we compare iteratively from 1 to 'a' in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
