alamb opened a new pull request, #12629:
URL: https://github.com/apache/datafusion/pull/12629

   ## Which issue does this PR close?
   
   Follow on to https://github.com/apache/datafusion/pull/12395 from @Rachelint 
   
   
   ## Rationale for this change
   
   Part of reviewing https://github.com/apache/datafusion/pull/12395I spent 
some non trivial time reading this code, and I wanted to encodde my learnings 
as comments
   
   ## What changes are included in this PR?
   
   1. Add comments to various functions
   2. Update parameter names
   
   ## Are these changes tested?
   No code, just docs and name changes
   
   ## Are there any user-facing changes?
   No, this is all internal code
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to