alamb commented on code in PR #12629: URL: https://github.com/apache/datafusion/pull/12629#discussion_r1777700951
########## datafusion/functions/src/string/common.rs: ########## @@ -35,19 +35,26 @@ use datafusion_expr::ColumnarValue; /// Append a new view to the views buffer with the given substr /// -/// raw must be a valid view -/// substr must be a valid substring of raw +/// # Safety +/// original_view must be a valid view Review Comment: Good call -- I tried to clarify in c8668df3b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
