andygrove commented on code in PR #968:
URL: https://github.com/apache/datafusion-comet/pull/968#discussion_r1776037634
##########
common/src/test/java/org/apache/comet/parquet/TestFileReader.java:
##########
@@ -615,12 +617,12 @@ public void testColumnIndexReadWrite() throws Exception {
@Test
public void testWriteReadMergeScanRange() throws Throwable {
Configuration conf = new Configuration();
- conf.set(ReadOptions.COMET_IO_MERGE_RANGES, Boolean.toString(true));
+ conf.set(CometConf.COMET_IO_MERGE_RANGES().key(), Boolean.toString(true));
Review Comment:
This test is setting the config values in a Hadoop Configuration still, and
not setting them in the Spark config. Would it make sense to update the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
