Rachelint commented on code in PR #12332:
URL: https://github.com/apache/datafusion/pull/12332#discussion_r1776203466
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -1024,11 +1017,7 @@ impl GroupedHashAggregateStream {
/// Note: currently spilling is not supported for Partial aggregation
fn update_skip_aggregation_probe(&mut self, input_rows: usize) {
if let Some(probe) = self.skip_aggregation_probe.as_mut() {
- if !self.spill_state.spills.is_empty() {
Review Comment:
Should we add another assert to ensure and emphasize that the `update_state`
is only called in `Partial` mode?
```rust
...
assert!(self.spill_state.spills.is_empty() && self.mode ==
AggregateMode::Partial);
probe.update_state(input_rows, self.group_values.len());
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
