jayzhan211 commented on PR #12631: URL: https://github.com/apache/datafusion/pull/12631#issuecomment-2376350199
I have some suggestion 1. It would be nice if there is a reproducible example so we could find out why and where metadata loss. It could also avoid breaking your case again if we added the metadata check back again without fixing the real issue. 2. If the reproducible example is hard to find, we could avoid the metadata check but other than `logically_equivalent_names_and_types` we need to check `nullable` as well. Try modify the `logically_equivalent_names_and_types` or create another new function that checks `nullable`. Also, add a TODO aside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
