jayzhan211 commented on PR #12631: URL: https://github.com/apache/datafusion/pull/12631#issuecomment-2378161907
> I think this is a reasonable change, but it does, as you say, potentially cause silent errors rather than explicit ones. > > This is a good idea for Influx, but maybe not as good an idea for other users of DataFusion > > Something we have done in the past for situations like this was to have a [config flag](https://datafusion.apache.org/user-guide/configs.html) that could control the behavior > > For example, this flag > > ``` > datafusion.optimizer.skip_failed_rules > ``` > > Controls if a failure in an optimizer rule would reject the entire plan or just skip that particular failed rule > > Perhaps we could make a similar flag for schema checks like > > ``` > datafusion.optimizer.only_compare_logical_types > ``` > > Or something 🤔 Does `only_compare_logical_types` includes `nullable`? If yes, it looks good to me. If not should we need another `only_compare_logical_types_with_nullable` flag as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
