jayzhan211 commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776729857
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
The rough idea is as the following:
As long as we have `Schema` we can get the `DataType`, and we can get the
LogicalType from it if each DataType has at most one LogicalType. `ScalarValue`
is just a wrapper for the scalar case of `ArrayRef` or rust native type. We can
carry `String` for `Utf8` / `Utf8View` / `LargeUtf8` and decode it if needed,
and also carry `Scalar<ArrayRef>` for `List` / `LargeList` and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
