findepi commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1776481456
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
> , it contains `ScalarValue::String` + `DataType`
so a number is stored as "5"?
how do i compare two float scalar values? i need to parse them?
how do i represent a constant (aka "literal") of type `array<row<a:
map<string, array<row<a: int, b: int>>>>>`?
i do believe constants in the plan are better expressed in their native
representation, like we did in `ScalarValue` (or via `Any`, as long as we have
type information needed to cast it back)
i guess this is a similar concern to one raised by @alamb here:
https://github.com/apache/datafusion/pull/12536#discussion_r1774086062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
