tokoko commented on code in PR #12800:
URL: https://github.com/apache/datafusion/pull/12800#discussion_r1792258366
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -783,7 +783,6 @@ pub async fn from_substrait_rel(
let t = ctx.table(table_reference.clone()).await?;
let t = ensure_schema_compatability(t, substrait_schema)?;
- let t = t.into_optimized_plan()?;
extract_projection(t, &read.projection)
Review Comment:
@Blizzara fixed with the approach outlined above. btw, turns out there was a
[test](https://github.com/apache/datafusion/blob/c412c74a7e6874ee09b1749aec6fd2a0bc72faed/datafusion/substrait/tests/cases/substrait_validations.rs#L120)
already that caught this, but apparently I did a classic rookie move in my
initial commit and fixed the test instead of fixing the code :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
