tokoko commented on code in PR #12800:
URL: https://github.com/apache/datafusion/pull/12800#discussion_r1792346770
##########
datafusion/substrait/tests/cases/substrait_validations.rs:
##########
@@ -104,20 +103,18 @@ mod tests {
);
// the DataFusion schema { b, a, c, d } contains the Substrait
schema { a, b, c }
Review Comment:
missed this. yes, before this, the naive wrong implementation yielded [b, a]
which looked way too similar to [a, b]. now it will be [d, a].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
