alamb commented on code in PR #12768:
URL: https://github.com/apache/datafusion/pull/12768#discussion_r1793825311
##########
datafusion/expr-common/src/operator.rs:
##########
@@ -142,10 +142,11 @@ impl Operator {
)
}
- /// Return true if the operator is a comparison operator.
+ /// Return true if the comparison operator can be used in interval
arithmetic and constraint
+ /// propagation
///
- /// For example, 'Binary(a, >, b)' would be a comparison expression.
- pub fn is_comparison_operator(&self) -> bool {
+ /// For example, 'Binary(a, >, b)' expression supports propagation.
+ pub fn supports_propagation(&self) -> bool {
Review Comment:
this is technically an API change -- Can you please avoid the change and
help people upgrade by adding back `is_comparison_operator` that calls
`supports_propagation` and mark it deprecated?
https://github.com/apache/datafusion/blob/3353c061830dbd1ef912736fee8426ee0405a3f9/datafusion/core/src/datasource/file_format/parquet.rs#L610-L619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
