blaginin commented on PR #12768: URL: https://github.com/apache/datafusion/pull/12768#issuecomment-2422737991
hey @berkaysynnada, I found the name is_comparison_operator a bit confusing because it’s not consistent with the documentation. For example: <img width="794" alt="Arc 2024-10-18 16 24 20" src="https://github.com/user-attachments/assets/a56b65a6-78f8-4702-83e3-c0580cc4db44";> > do you have a preferred new name for supports_propagation() considering its use only in unwrap_cast_in_comparison.rs Since it’s only for `unwrap_cast_in_comparison.rs`, maybe we could rename it to something like `supports_unwrap_cast`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
