duongcongtoai commented on code in PR #12836:
URL: https://github.com/apache/datafusion/pull/12836#discussion_r1793954013
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3300,39 +3300,6 @@ pub enum Partitioning {
DistributeBy(Vec<Expr>),
}
-/// Represents the unnesting operation on a column based on the context (a
known struct
-/// column, a list column, or let the planner infer the unnesting type).
-///
-/// The inferred unnesting type works for both struct and list column, but the
unnesting
-/// will only be done once (depth = 1). In case recursion is needed on a
multi-dimensional
-/// list type, use [`ColumnUnnestList`]
-#[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd)]
-pub enum ColumnUnnestType {
Review Comment:
This struct is now a part of the builder, no need to expose to api
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1593,14 +1573,13 @@ impl TableSource for LogicalTableSource {
/// Create a [`LogicalPlan::Unnest`] plan
pub fn unnest(input: LogicalPlan, columns: Vec<Column>) -> Result<LogicalPlan>
{
- let unnestings = columns
- .into_iter()
- .map(|c| (c, ColumnUnnestType::Inferred))
- .collect();
+ let unnestings = columns.into_iter().map(|c| c).collect();
unnest_with_options(input, unnestings, UnnestOptions::default())
}
-pub fn get_unnested_list_datatype_recursive(
Review Comment:
remove this method, recursion specification can be declared using
UnnestOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
