duongcongtoai commented on code in PR #12836:
URL: https://github.com/apache/datafusion/pull/12836#discussion_r1807737579
##########
datafusion/sql/src/select.rs:
##########
@@ -440,11 +460,31 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
};
projection_exprs.extend(inner_projection_exprs);
+ let mut list_recursions = vec![];
+ let unnest_col_vec = unnest_columns
+ .into_iter()
+ .map(|(col, maybe_list_unnest)| {
+ match maybe_list_unnest {
+ None => {}
+ Some(list_unnest) => {
+
list_recursions.extend(list_unnest.into_iter().map(
+ |unnest_list| RecursionUnnestOption {
+ input_column: col.clone(),
+ output_column:
unnest_list.output_column,
+ depth: unnest_list.depth,
+ },
+ ));
+ }
+ }
Review Comment:
true, i can refactor this function so it returns 3 result:
- inner_projection_exprs
- unnest_placeholder_columns
- outer_projection_exprs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
